add names to test cases #1417
Draft
add names to test cases #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_test_names
branch
3 times, most recently
from
ff1b773 to
56819a9
Compare
KFilipek
requested changes
Jul 7, 2025
test/coarse_lib.cpp
Outdated
Comment on lines
118
to
124
| ([](auto const &info) { | ||
| const char *names[] = {"UMF_COARSE_MEMORY_STRATEGY_FASTEST", | ||
| "UMF_COARSE_MEMORY_STRATEGY_FASTEST_BUT_ONE", | ||
| "UMF_COARSE_MEMORY_STRATEGY_CHECK_ALL_SIZE"}; | ||
| return names[info.index]; | ||
| })); |
There was a problem hiding this comment.
Undefined behavior: I'm pretty sure that the automatic variable will be destroyed after the function return.
Please fix all occurrences.
There was a problem hiding this comment.
changed to std::string
bratpiorka
force-pushed
the
rrudnick_test_names
branch
7 times, most recently
from
d0a9cb1 to
3e20354
Compare
bratpiorka
force-pushed
the
rrudnick_test_names
branch
from
3e20354 to
f27926a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.